Messages in this thread | | | Date | Thu, 24 Mar 2011 09:25:23 +0100 | From | Tejun Heo <> | Subject | Re: [Uclinux-dist-devel] [RFC PATCH] percpu: always align percpu output section to PAGE_SIZE |
| |
Hello,
On Thu, Mar 24, 2011 at 02:46:01AM -0400, Mike Frysinger wrote: > On Tue, Oct 26, 2010 at 10:06, Tejun Heo wrote: > > The linker script macros PERCPU_VADDR() and PERCPU() are used to > > define this output section and the latter takes @align parameter. > > Several architectures are using @align smaller than PAGE_SIZE breaking > > percpu memory alignment. > > hmm, i just pushed through a fix in the Blackfin tree as we hit a boot > failure otherwise: > - PERCPU(4) > + PERCPU(PAGE_SIZE) > > > This patch removes @align parameter from PERCPU(), renames it to > > PERCPU_SECTION and makes it always align to PAGE_SIZE. While at it, > > add PCPU_SETUP_BUG_ON() checks such that alignment problems are > > reliably detected and remove percpu alignment comment recently added > > in workqueue.c as the condition would trigger BUG way before reaching > > there. > > seems this still hasnt made it to mainline. has it stalled or > something ? feel free for the Blackfin bits: > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Heh, I just forgot. I'll queue it with your Acked-by added.
Thanks.
-- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |