lkml.org 
[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip] perf, x86: P4 PMU - Add missing read of a counter before test

* Cyrill Gorcunov <gorcunov@gmail.com> wrote:

> Unflagged overflows never have been catched due to missed read of a register which
> is to signalize about it, and as result unknown nmi may happen leading to
> "Dazen and confused" message. That is what supposed to be in changelog?

Exactly, the 'Dazed and confused' message is *all* that the user cares about so
it must feature prominently in the changelog.

If a P4 user searches lkml he wants to know which fixed address
dazed-and-confused messages. He will know nothing about 'unflagged overflows'
or other internals ...

All the other details about how the patch does the fix is secondary to what
users experience when they hit this bug.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-03-24 17:55    [from the cache]
©2003-2011 Jasper Spaans