Messages in this thread | | | Date | Thu, 24 Mar 2011 09:02:04 -0700 | From | Randy Dunlap <> | Subject | Re: [origin tree build failure] Re: [PATCH] fs, coda: Fix compile warning when CONFIG_SYSCTL=n. |
| |
On Thu, 24 Mar 2011 16:46:15 +0600 Rakib Mullick wrote:
> On Thu, Mar 24, 2011 at 1:54 PM, Ingo Molnar <mingo@elte.hu> wrote: > > > > * Rakib Mullick <rakib.mullick@gmail.com> wrote: > > > >> When CONFIG_SYSCTL=n, we get the following warning: > >> > >> fs/coda/sysctl.c:18: warning: ‘coda_table’ defined but not used > >> > >> Following patches fixes the above warning by making sure coda_table > >> and it's callee > >> function are in the same context. It also cleans up the code by > >> removing extra #ifdef. > >> > >> > >> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> > >> --- > >> > >> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c > >> index c6405ce..d9cc2b3 100644 > >> --- a/fs/coda/sysctl.c > >> +++ b/fs/coda/sysctl.c > > > > FYI, the v2 of this patch: > > > > 0bc825d240ab: codafs: fix compile warning when CONFIG_SYSCTL=n > > > > broke the upstream build: > > > > fs/built-in.o: In function `init_coda': > > psdev.c:(.init.text+0x2549): undefined reference to `coda_sysctl_clean' > > fs/built-in.o: In function `exit_coda': > > psdev.c:(.exit.text+0x1bf): undefined reference to `coda_sysctl_clean' > > fs/built-in.o: In function `init_coda_psdev': > > psdev.c:(.text.unlikely+0x21e1): undefined reference to `coda_sysctl_init' > > > > I don't think the -v2 commit was build-tested with !CONFIG_PROC_SYSCTL && > > CONFIG_CODA_FS=y. > > > Andrew cleans up the unnecessary stubs. But, clearly removed > definition is necessary. And Yes, you are right, I didn't build test > it. Sorry for that. Please consider the following patch. > > --- > codafs: Fix build break when CONFIG_PROC_SYSCTL=n > > Commit 0bc825d240ab (codafs: fix compile warning when > CONFIG_SYSCTL=n), introduces build breakage, when CONFIG_PROC_SYSCTL=n > and CONFIG_CODA_FS=y. This patch fixes it. > > fs/built-in.o: In function `init_coda': > psdev.c:(.init.text+0xc02): undefined reference to `coda_sysctl_init' > psdev.c:(.init.text+0xc7c): undefined reference to `coda_sysctl_clean' > fs/built-in.o: In function `exit_coda': > psdev.c:(.exit.text+0xa9): undefined reference to `coda_sysctl_clean' > make: *** [.tmp_vmlinux1] Error 1 > > Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> > Reported-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
> --- > > diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c > index 06d27a4..af56ad5 100644 > --- a/fs/coda/sysctl.c > +++ b/fs/coda/sysctl.c > @@ -61,4 +61,13 @@ void coda_sysctl_clean(void) > fs_table_header = NULL; > } > } > + > +#else > +void coda_sysctl_init(void) > +{ > +} > + > +void coda_sysctl_clean(void) > +{ > +} > #endif > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |