lkml.org 
[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: core: Change usb_create_sysfs_intf_files()' return type to void
On Thu, 24 Mar 2011, Michal Nazarewicz wrote:

> From: Michal Nazarewicz <mina86@mina86.com>
>
> The usb_create_sysfs_intf_files() function always returned zero even
> if it failed to create sysfs fails. Since this is a desired behaviour
> there is no need to return return code at all. This commit changes
> function's return type (form int) to void.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> ---
> drivers/usb/core/sysfs.c | 7 +++----
> drivers/usb/core/usb.c | 3 +--
> drivers/usb/core/usb.h | 2 +-
> 3 files changed, 5 insertions(+), 7 deletions(-)
>
> The below patch has not been tested (not even compiled), just a quick scatch.

If you had compiled it, you would have seen why it's not a good idea to
remove retval. :-)

On the other hand, changing the function's return type to void is okay.
I think the reason it returns int is historical; there used to be a
failure mode but it got removed.

Alan Stern



\
 
 \ /
  Last update: 2011-03-24 16:55    [W:0.092 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site