lkml.org 
[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: check device_create_file() return code in usb_create_sysfs_intf_files()
On Thu, 24 Mar 2011, Sergey Senozhatsky wrote:

> Hello,
>
> I just noticed that usb_create_sysfs_intf_files() ignores device_create_file()
> return code and sets intf->sysfs_files_created to 1, even if sysfs_add_file_mode()
> returned -ENOMEM (or later sysfs_add_one() returned -EEXIST).
>
> Shouldn't we check retval for 0 before setting intf->sysfs_files_created?

No. We want this routine to succeed even if the sysfs files can't be
created. The interface string attribute is more or less optional.

It would be okay to add a comment explaining this, so that other people
don't make the same mistake (which has already happened -- you're not
the first).

Alan Stern



\
 
 \ /
  Last update: 2011-03-24 15:57    [W:0.033 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site