[lkml]   [2011]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 1/7] mfd: add pruss mfd driver.

> A device may be de-initialized and another loaded or two different devices
> can be run simultaneously on the two cores.
> It's also possible, as in our case, to implement a single device on both
> the PRU's resulting in improved load sharing.

>Make you driver compile with sparse "make C=1", you cast way too much
>when accessing io mem. Use void __iomem * instead of u32 *.

With make C=1 I am receiving some warnings such as:

warning: cast removes address space of expression
drivers/mfd/da8xx_pru.c:61:17: warning: incorrect type in argument 1
(different base types)
drivers/mfd/da8xx_pru.c:61:17: expected void const volatile [noderef]
drivers/mfd/da8xx_pru.c:61:17: got int
drivers/mfd/da8xx_pru.c:66:28: warning: incorrect type in argument 1
(different address spaces)

I can remove all of these by casting to (__force void __iomem *) but is
this correct.


 \ /
  Last update: 2011-03-24 14:17    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean