lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/7] TTY: serial_core, remove unused variable
On Wed, Mar 23, 2011 at 2:19 PM, Jiri Slaby <jslaby@suse.cz> wrote:
> drivers/tty/serial/serial_core.c:1980:2: warning: Value stored to 'tty' is never read
>        tty = port->tty;
>        ^     ~~~~~~~~~
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>


Acked-by: Govindraj.R <govindraj.raja@ti.com>


> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: linux-serial@vger.kernel.org
> ---
>  drivers/tty/serial/serial_core.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index 733fe8e..d6e7240 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1972,13 +1972,9 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
>        struct tty_port *port = &state->port;
>        struct device *tty_dev;
>        struct uart_match match = {uport, drv};
> -       struct tty_struct *tty;
>
>        mutex_lock(&port->mutex);
>
> -       /* Must be inside the mutex lock until we convert to tty_port */
> -       tty = port->tty;
> -
>        tty_dev = device_find_child(uport->dev, &match, serial_match_port);
>        if (device_may_wakeup(tty_dev)) {
>                if (!enable_irq_wake(uport->irq))
> --
> 1.7.4.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-serial" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-03-23 10:19    [from the cache]
©2003-2011 Jasper Spaans