Messages in this thread | | | Date | Wed, 23 Mar 2011 08:31:27 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH v2] cfq-iosched: Don't clear queue stats when preempt. |
| |
On 2011-03-22 23:35, Justin TerAvest wrote: > For v2, I added back lines to cfq_preempt_queue() that were removed > during updates for accounting unaccounted_time. Thanks for pointing out > that I'd missed these, Vivek. > > Previous commit "cfq-iosched: Don't set active queue in preempt" wrongly > cleared stats for preempting queues when it shouldn't have, because when > we choose a queue to preempt, it still isn't necessarily scheduled next. > > Thanks to Vivek Goyal for figuring this out and understanding how the > preemption code works.
Thanks to both of you, applied.
-- Jens Axboe
| |