lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Add a kstrtobool function matching semantics of existing in kernel equivalents.
On Wed, Mar 23, 2011 at 05:30:11PM +0200, Alexey Dobriyan wrote:
> On Wed, Mar 23, 2011 at 3:39 PM, Jonathan Cameron <jic23@cam.ac.uk> wrote:
> > +int kstrtobool(const char *s, bool *res)
> > +{
> > +       switch (s[0]) {
> > +       case 'y':
> > +       case 'Y':
> > +       case '1':
> > +               *res = true;
> > +       case 'n':
> > +       case 'N':
> > +       case '0':
> > +               *res = false;
> > +       default:
> > +               return -EINVAL;
> > +       }
> > +       return 0;
> > +}
>
> sigh... such simple thing and so many bugs
>
> The only values such function should accept is 0 and 1.

Why? That's not the way the existing kernel functions that use this
work.

> Have you read the rest of kstrto*() code?
> Where is newline check?
>
> Anyway, I think it's better do not exist.

I think it is, as it's already duplicated in at least 2 different places
in the kernel, and probably more. Once we get this implementation
working correctly, we don't need to rewrite it again.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-03-23 17:07    [W:0.086 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site