Messages in this thread Patch in this message | | | From | Jonathan Cameron <> | Subject | [PATCH 2/3] debugfs: move to new kstrtobool function | Date | Wed, 23 Mar 2011 13:39:13 +0000 |
| |
No functional changes requires that we eat errors from kstrtobool. Note *val is still only updated if a valid input is found.
Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk> --- fs/debugfs/file.c | 19 ++++++------------- 1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 89d394d..fed4485 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -429,25 +429,18 @@ static ssize_t write_file_bool(struct file *file, const char __user *user_buf, { char buf[32]; int buf_size; + int ret; + bool bv; u32 *val = file->private_data; buf_size = min(count, (sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; - switch (buf[0]) { - case 'y': - case 'Y': - case '1': - *val = 1; - break; - case 'n': - case 'N': - case '0': - *val = 0; - break; - } - + ret = kstrtobool(buf, &bv); + if (!ret) + *val = bv; + return count; } -- 1.7.3.4
| |