lkml.org 
[lkml]   [2011]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/20] job control: Small reorganization of wait_consider_task()
    Date
    Move EXIT_DEAD test in wait_consider_task() above ptrace check.  As
    ptraced tasks can't be EXIT_DEAD, this change doesn't cause any
    behavior change. This is to prepare for further changes.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Acked-by: Oleg Nesterov <oleg@redhat.com>
    ---
    kernel/exit.c | 7 ++++---
    1 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/kernel/exit.c b/kernel/exit.c
    index f9a45eb..b4a935c 100644
    --- a/kernel/exit.c
    +++ b/kernel/exit.c
    @@ -1537,6 +1537,10 @@ static int wait_consider_task(struct wait_opts *wo, int ptrace,
    return 0;
    }

    + /* dead body doesn't have much to contribute */
    + if (p->exit_state == EXIT_DEAD)
    + return 0;
    +
    if (likely(!ptrace) && unlikely(task_ptrace(p))) {
    /*
    * This child is hidden by ptrace.
    @@ -1546,9 +1550,6 @@ static int wait_consider_task(struct wait_opts *wo, int ptrace,
    return 0;
    }

    - if (p->exit_state == EXIT_DEAD)
    - return 0;
    -
    /*
    * We don't reap group leaders with subthreads.
    */
    --
    1.7.1


    \
     
     \ /
      Last update: 2011-03-23 11:09    [W:0.022 / U:30.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site