lkml.org 
[lkml]   [2011]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
Harry Wei wrote:
> Hi us,
> Clean up CodingStyle for scripts/kconfig/gconf.c.
>

What makes you think this is a bad style? Does Documentation/CodingStyle say
so? Does checkpatch.pl make a complain? Do you really think this improves
readability? I don't think so, and actually it makes the code worse.

Run checkpatch.pl on this file, and you'll see lots of errors and warnings,
but pure codingstyle cleanup is rarely worth anything, so better don't do
that.

> Thanks.
> Best Regards.
> Harry Wei.
>
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> ---
> scripts/kconfig/gconf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 4558961..56da945 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -7,7 +7,7 @@
> */
>
> #ifdef HAVE_CONFIG_H
> -# include <config.h>
> +#include <config.h>
> #endif
>
> #include "lkc.h"


\
 
 \ /
  Last update: 2011-03-23 02:43    [W:0.061 / U:1.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site