Messages in this thread | | | From | "Guan Xuetao" <> | Subject | RE: [PATCH] ARM: Use asm-generic/sizes.h | Date | Wed, 23 Mar 2011 09:29:46 +0800 |
| |
> -----Original Message----- > From: Stephen Boyd [mailto:sboyd@codeaurora.org] > Sent: Wednesday, March 23, 2011 2:40 AM > To: Guan Xuetao > Cc: 'Arnd Bergmann'; linux-arm-kernel@lists.infradead.org; 'Russell King - ARM Linux'; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ARM: Use asm-generic/sizes.h > > On 03/22/2011 06:43 AM, Guan Xuetao wrote: > > And I just complete the SZ_* definitions for 32-bit architecture, > > and remove SZ_48M for not being power-of-2 size. > > Ah, I didn't notice this part. SZ_48M is actually used by ARM code so > that would need to be added to the generic header should we go with this > patch.
IMO, the content of asm-generic/sizes.h should only include power-of-2 sizes definitions. And SZ_48M could be replaced by (SZ_32M | SZ_16M) or (SZ_32M + SZ_16M), or added to arch-specific headers.
Guan Xuetao
| |