lkml.org 
[lkml]   [2011]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCHSET] ptrace,signal: Fix notifications to the real parent while ptraced
    On 03/22, Tejun Heo wrote:
    >
    > Hello, Oleg.
    >
    > The updated patches should address the issues pointed out in your
    > reviews, at least the ones which are appropriate to address now.

    Yes, thanks. "UPDATED" patches look fine. Please feel free to add my
    reviewed-by to the whole series.

    I'd only ask you to remove ->group_leader from real_parent_is_ptracer()
    (btw, note that wait_consider_task() can use this helper too) although
    this is minor.

    > Please let me know when you want the whole series resent.

    Cough. Resent? If you ask me, I think you should just send them to
    Linus while the merge window is opened.

    I am trying to get the account on kernel.org, but until then I hope
    you can flush the pending ptrace-review branches.



    In case I misunderstood you... I think that the whole series is good
    and the patches should not be updated. Just for example, I'd like to
    rename real_parent_is_ptracer (and remove ->group_leader), but we can
    make another patch for that.

    And yes, I bet we missed something and we will need the subsequent
    fixes anyway ;)

    Oleg.



    \
     
     \ /
      Last update: 2011-03-22 22:11    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean