Messages in this thread | | | Date | Tue, 22 Mar 2011 13:56:19 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH 3/3] memcg: move page-freeing code outside of lock |
| |
On Tue, 22 Mar 2011 12:04:39 +0900 Namhyung Kim <namhyung@gmail.com> wrote:
> 2011-03-22 (화), 08:59 +0900, KAMEZAWA Hiroyuki: > > On Fri, 18 Mar 2011 21:54:15 +0900 > > Namhyung Kim <namhyung@gmail.com> wrote: > > > > > Signed-off-by: Namhyung Kim <namhyung@gmail.com> > > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > > > What is the benefit of this patch ? > > > > -Kame > > > > Oh, I just thought generally it'd better call such a (potentially) > costly function outside of locks and it could reduce few of theoretical > contentions between swapons and/or offs. If it doesn't help any > realistic cases I don't mind discarding it. >
My point is, please write patch description which shows for what this patc is. All cleanup are okay to me if it reasonable. But without patch description as "this is just a cleanup, no functional change, and the reason is...." we cannot maintain patches.
Thanks, -Kame
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |