lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v2] Utilize the PCI API in the TTM framework.
    On Mon, Mar 21, 2011 at 02:11:07PM +0100, Michel Dänzer wrote:
    > On Fre, 2011-01-07 at 12:11 -0500, Konrad Rzeszutek Wilk wrote:
    > >
    > > 1) The 'NULL' when doing dma_alloc_coherent is unsightly. I was toying
    > > with modifying the TTM API to pass in 'struct device' or 'struct pci_device'
    > > but figured it would make first sense to get your guys input before heading that route.
    >
    > It's worse than unsightly: It breaks TTM on PPC. See
    > arch/powerpc/include/asm/dma-mapping.h: get_dma_ops() returns NULL if
    > NULL is passed in for the device, and most of its callers BUG in that
    > case. The exception being dma_supported(), so a possible solution might
    > be to use that for checking if dma_alloc_coherent can be used.
    >
    > Dave, please prevent this change from entering mainline before there's a
    > solution for this.

    We do have a fix for it:

    git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git devel/ttm.pci-api.v5

    Can you tell me if that works for you?
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-03-22 00:45    [W:0.026 / U:93.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site