lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH v3 09/22] mm, s390: add gfp flags variant of pud, pte, and pte allocations
    On Fri, 18 Mar 2011 19:56:44 +0000
    Prasad Joshi <prasadjoshi124@gmail.com> wrote:

    > - Added function __crst_table_alloc() which is similar to crst_table_alloc()
    > but accepts an extra argument gfp_t. The function uses given allocation
    > flag to allocate pages.
    >
    > - Added a function __page_table_alloc() to allocate page table entries. This
    > function is allows caller to specify the page allocation flag. The
    > allocation flag is then passed to alloc_page(). The rest of the function is
    > copy of the original page_table_alloc().

    The approach of this patch series seems straightforward, the only nitpick I
    have is the fact that two new functions __crst_table_alloc/__page_table_alloc
    are introduced. There aren't many call sites for the two original functions,
    namely 4 for crst_table_alloc and 3 for page_table_alloc. Why not add the
    gfp flag GFP_KERNEL to these call sites? Then the two additional functions
    would not be needed.

    --
    blue skies,
    Martin.

    "Reality continues to ruin my life." - Calvin.



    \
     
     \ /
      Last update: 2011-03-21 09:37    [W:0.022 / U:0.084 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site