Messages in this thread | | | Date | Mon, 21 Mar 2011 19:05:26 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86, UV: Fix NMI handler for UV platforms |
| |
* Jack Steiner <steiner@sgi.com> wrote:
> static notrace __kprobes void default_do_nmi(struct pt_regs *regs) > { > unsigned char reason = 0; > + int handled; > > /* > * CPU-specific NMI must be processed before non-CPU-specific > * NMI, otherwise we may lose it, because the CPU-specific > * NMI can not be detected/processed on other CPUs. > */ > - if (notify_die(DIE_NMI, "nmi", regs, 0, 2, SIGINT) == NOTIFY_STOP) > + handled = x86_platform.nmi_handler(regs); > + if (notify_die(DIE_NMI, "nmi", regs, 0, 2, SIGINT) == NOTIFY_STOP || > + handled) > return;
This would indeed be cleaner and would work better - given how unreliable it is to demultiplex NMI reasons.
Thanks,
Ingo
| |