lkml.org 
[lkml]   [2011]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] job control: Allow access to job control events through ptracees
Hello,

On Mon, Mar 21, 2011 at 05:39:50PM +0100, Oleg Nesterov wrote:
> > @@ -1580,15 +1582,37 @@ static int wait_consider_task(struct wait_opts *wo, int ptrace,
> > wo->notask_error = 0;
> > } else {
> > /*
> > + * If %current is ptracing @p, hide group stop/continued
> > + * state when looking at @p as the real parent; otherwise,
> > + * a single stop can be reported twice as group and ptrace
> > + * stops.
> > + *
> > + * If a ptracer wants to distinguish the two events for its
> > + * own children, it should create a separate task which
> > + * takes the role of real parent.
> > + */
> > + if (likely(!ptrace) && task_ptrace(p) && p->parent == current)
> > + return 0;
>
> This doesn't look exactly right. Ignoring __WNOTHREAD, do_wait() should work
> the same way for every thread in parent/debugger's thread group. IOW, we
> should probably check same_thread_group(p->parent, p->real_parent) instead
> of "== current".

Alright, I'll update the test here and in the other patch which has
similar logic.

BTW, what are you planning about patch routing? Are you gonna setup a
tree?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-03-21 18:29    [W:0.187 / U:9.640 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site