Messages in this thread | | | Date | Mon, 21 Mar 2011 17:11:02 +0100 | From | Ingo Molnar <> | Subject | Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1 |
| |
* Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Mar 21, 2011 at 04:37:19PM +0100, Ingo Molnar wrote: > > > has been pushed upstream - although the build breakage was reported against > > linux-next two weeks ago, with fix provided, in this lkml thread: > > > > [PATCH -next] soc: sgtl5000 uses regulator interfaces > > Zheng, you said you'd provide a better patch for this but I've heard > nothing since? It's a trivial change you need to make... > > > Please do not push known-broken code upstream. > > That seems like an overreaction, it'll only show up in fairly unrealstic > randconfigs [...]
I've seen it trigger with a likelyhood of about 20%, that's not unrealistic.
> [...] and can be trivially avoided by anyone who actually needs the driver - > core things like all*config won't be affected, and right now it'll only come > up at all if you enable SND_SOC_ALL_CODECS which is purely about build > coverage. > > > Randy's fix below resolved the bug for me. > > As indicated that's not a good fix since the affected code is all runtime > conditional already. [...]
Well, AFAICS Randy's patch correctly expresses current infrastructure dependencies the driver has.
If it's undesirable to disable the driver in the (unlikely but possible) SND_SOC_ALL_CODECS=y but !REGULATOR case, i.e. if it's desirable to have the driver build more widely, then that can be enhanced further - but first please get things to build.
> [...] It'd be more likely to impede than help the sort of build coverage > tests where one would encounter it.
It's an invariant mostly - both Randy's and my testing will find breakages regardless of how restrictively enabled this driver is.
Thanks,
Ingo
| |