Messages in this thread | | | Date | Mon, 21 Mar 2011 17:59:48 +0300 | From | Dan Carpenter <> | Subject | Re: [patch] rapidio: potential null deref on failure path |
| |
On Mon, Mar 21, 2011 at 05:49:06AM -0700, Bounine, Alexandre wrote: > Better to combine both conditions: > > if (rio_is_switch(rdev) && rswitch->route_table)) > kfree(rswitch->route_table); > > Because there is situation when routine fails to allocate route_table > for a switch. >
kfree() accepts NULL pointers. People have been removing these checks all over the tree by the hundreds... Sorry I should have mentioned that.
regards, dan carpenter
| |