Messages in this thread | | | Date | Sun, 20 Mar 2011 14:39:13 +0100 | From | Arne Jansen <> | Subject | aligning with spaces [was: Re: format fixes] |
| |
On 20.03.2011 11:45, Jeffrin Jose wrote: > I have created a patch with fixes and format > error by replacing spaces with tabs.
The CodingStyle guide seems to me a big vague on this topic, but checkpatch.pl has a clear idea of what is right and wrong. But the formerly present indentation seems to me totally valid. Use tab to indent to the current indentation level, then continue with spaces for the alignment of broken-up lines. This has a few advantages. One of them is that the code still looks neat with a different tab size (of course, no one ever does that). Another is, that editing is easier if you change the name of the function and with it the needed alignment for the following lines. If we really require using tabs as much as possible for aligning, we should also _only_ use tabs for it and require e.g. 2 tabs for broken-up lines. In fact, the example in CodingStyle uses only tabs and does not try to align the double quotes of the broken-up string with each other.
--Arne
| |