[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] perf: Set filters before mmaping events

    * Frederic Weisbecker <> wrote:

    > We currently set the filters after we mmap the events, this is a
    > race that let undesired events record themselves in the buffer before
    > we had the time to set the filters.
    > So set the filters before they can be recorded. That also librarizes
    > the filters setting so that filtering can be done more easily
    > from other tools than perf record later.
    > (PS: This should fix most of the bugs Ingo has reported
    > about filters that weren't working with perf).


    Mind pulling Steve's filter-enhancements branch and sending a pull request for the
    whole thing? Steve's branch was:

    git:// tip/perf/filter

    ( Or your fixes could be applied to Steve's branch as well - whichever direction you
    guys prefer - the important thing is to have filtering tested and validated as a
    whole. )



     \ /
      Last update: 2011-03-02 09:51    [W:0.023 / U:0.752 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site