Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH v3 4/4] exec: document acct_arg_size() | Date | Thu, 3 Mar 2011 12:09:25 +0900 (JST) |
| |
> Add the comment to explain acct_arg_size(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > --- > > fs/exec.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > --- 38/fs/exec.c~4_doc_acct_arg_size 2011-03-02 16:21:57.000000000 +0100 > +++ 38/fs/exec.c 2011-03-02 16:27:24.000000000 +0100 > @@ -164,7 +164,12 @@ out: > } > > #ifdef CONFIG_MMU > - > +/* > + * The nascent bprm->mm is not visible until exec_mmap() but it can > + * use a lot of memory, account these pages in current->mm temporary > + * for oom_badness()->get_mm_rss(). Once exec succeeds or fails, we > + * change the counter back via acct_arg_size(0). > + */ > static void acct_arg_size(struct linux_binprm *bprm, unsigned long pages) > { > struct mm_struct *mm = current->mm; >
Yeah! Thank you very much to make proper and clear comment. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |