lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] net: don't allow CAP_NET_ADMIN to load non-netdev kernel modules
    Date

    I am probably missing something, but shouldn't the existing
    MODULE_ALIASes stay?

    Vasiliy Kulikov <segoon@openwall.com> writes:

    > diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
    > index 6613edf..d1d0e2c 100644
    > --- a/net/ipv4/ip_gre.c
    > +++ b/net/ipv4/ip_gre.c
    > @@ -1765,4 +1765,4 @@ module_exit(ipgre_fini);
    > MODULE_LICENSE("GPL");
    > MODULE_ALIAS_RTNL_LINK("gre");
    > MODULE_ALIAS_RTNL_LINK("gretap");
    > -MODULE_ALIAS("gre0");
    > +MODULE_ALIAS_NETDEV("gre0");

    that is, instead of replacing MODULE_ALIAS("gre0") with the NETDEV
    version, don't you want both for backward compatibility?

    (if so, same goes for the other two)

    jake

    --
    Jake Edge - jake@lwn.net - http://lwn.net


    \
     
     \ /
      Last update: 2011-03-02 20:51    [W:0.020 / U:31.104 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site