Messages in this thread | | | Date | Wed, 2 Mar 2011 10:12:53 -0600 | Subject | Re: [PATCH] omap:iommu-added cache flushing operation for L2 cache | From | "Gupta, Ramesh" <> |
| |
Hi Santosh,
On Wed, Mar 2, 2011 at 6:48 AM, Santosh Shilimkar <santosh.shilimkar@ti.com> wrote: > Hello, >> -----Original Message----- >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- >> owner@vger.kernel.org] On Behalf Of Fernando Guzman Lugo >> Sent: Wednesday, March 02, 2011 1:17 AM >> To: hiroshi.doyu@nokia.com >> Cc: tony@atomide.com; linux@arm.linux.org.uk; linux- >> omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux- >> kernel@vger.kernel.org; Ramesh Gupta; Hari Kanigeri >> Subject: [PATCH] omap:iommu-added cache flushing operation for L2 >> cache >> >> From: Ramesh Gupta <grgupta@ti.com> >> >> Signed-off-by: Ramesh Gupta <grgupta@ti.com> >> Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com> >> --- >> arch/arm/plat-omap/iommu.c | 22 ++++++++-------------- >> 1 files changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c >> index e3eb038..aeb2c33 100644 >> --- a/arch/arm/plat-omap/iommu.c >> +++ b/arch/arm/plat-omap/iommu.c >> @@ -471,22 +471,15 @@ EXPORT_SYMBOL_GPL(foreach_iommu_device); >> */ >> static void flush_iopgd_range(u32 *first, u32 *last) >> { >> - /* FIXME: L2 cache should be taken care of if it exists */ >> - do { >> - asm("mcr p15, 0, %0, c7, c10, 1 @ flush_pgd" >> - : : "r" (first)); >> - first += L1_CACHE_BYTES / sizeof(*first); >> - } while (first <= last); >> + dmac_flush_range(first, last); > > There is note just above this API.
Thank you for your inputs. I agree, I will send an updated patch with proper apis.
regards Ramesh Gupta G -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |