lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/6 v6] vfs: export do_splice_direct() to modules
From
Date
On Tue, 1 Mar 2011, richard -rw- weinberger wrote:
> > +EXPORT_SYMBOL(do_splice_direct);
>
> I have a question on your patch, why are you using EXPORT_SYMBOL()
> instead of EXPORT_SYMBOL_GPL()?
> Are you using EXPORT_SYMBOL() because all symbols in fs/splice.c
> are exported via EXPORT_SYMBOL()?
>
> To be more precise, are there any rules to decide when _GPL() should be used?
> IMHO we should always use _GPL() for new symbols.

I don't think there are any written rules.

I'd use EXPORT_SYMBOL() when the provided API is reasonably "clean"
(i.e. it hides the implementation well enough).

Thanks,
Miklos


\
 
 \ /
  Last update: 2011-03-02 13:47    [W:0.073 / U:4.472 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site