lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectMS_SILENT vs. vfat and hfs

    The mount(8) command uses "quiet" mount option as a synonym to the
    MS_SILENT mount flag (since util-linux 2.7, Aug 1997).

    It means than on systems where is properly defined the MS_SILENT
    mount flags in headers is the "quiet" mount option always translated
    to the MS_SILENT mount flags and "quiet" string is never send to FS
    drivers.

    $ strace -e mount mount -o quiet /dev/sdb1 /mnt/test
    mount("/dev/sdb1", "/mnt/test", "vfat", MS_MGC_VAL|MS_SILENT, NULL) = 0
    ^^^^^^^^^

    Unfortunately,

    $ grep -r \"quiet\" *

    fat/inode.c: {Opt_quiet, "quiet"},
    hfs/super.c: { opt_quiet, "quiet" },

    vfat and hfs drivers use "quiet" as a mount option. That's bug.

    There should not be a collision between mount(8) mount options and
    filesystem specific mount options.

    My suggestion is to fix the fat and hfs code to use something other
    than "quiet" (shutup, noisless, ...). I think you don't have to care
    about backward compatibility, because it's probably broken for years.

    Karel

    --
    Karel Zak <kzak@redhat.com>
    http://karelzak.blogspot.com


    \
     
     \ /
      Last update: 2011-03-02 12:47    [W:2.420 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site