lkml.org 
[lkml]   [2011]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH x86/mm] x86-64, NUMA: Fix distance table handling

* Tejun Heo <tj@kernel.org> wrote:

> FWIW, I'm not really decided about 80 vs. whatever column issue.

It only really matters when the underlying code structure is clearly inefficient:
too many indentations, etc.

but printks or function calls that go beyond 80 cols a bit do not deserve to be
line-broken.

> Having a common limit definitely helps a lot but it seems almost
> impossible to agree on one - is it 90, 95, 100 or 120? Given that, it
> almost seems just sticking to 80 might be the only doable solution.

The problem is that many sensible code structures break with a limit of 80.

So i'd suggest being permissive when the code is fine (printks, function calls at
the first or second level of indentation, etc.) and being conservative when the
underlying code is not fine.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-03-02 11:39    [W:0.126 / U:8.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site