[lkml]   [2011]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] arch/tile: fix futex sanitization definition/prototype mismatch
On Sat, Mar 19, 2011 at 8:45 AM, Chris Metcalf <> wrote:
> Commit 8d7718aa082aaf30a0b4989e1f04858952f941bc changed "int"
> to "u32" in the prototypes but not the definition.
> I missed this when I saw the patch go by on LKML.
> We cast "u32 *" to "int *" since we are tying into the underlying
> atomics framework, and atomic_t uses int as its value type.
> Signed-off-by: Chris Metcalf <>

Reviewed-by: Michel Lespinasse <>

Looks fine. I had held off from changing types within
futex_atomic_op_inuser() because the signed-ness of oparg and cmparg
was important there, but I agree changing at least the user pointer
types in futex_* operations is nice and safe.

Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

 \ /
  Last update: 2011-03-20 04:55    [W:0.036 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site