Messages in this thread | | | Date | Sat, 19 Mar 2011 20:52:56 -0700 | Subject | Re: [PATCH] arch/tile: fix futex sanitization definition/prototype mismatch | From | Michel Lespinasse <> |
| |
On Sat, Mar 19, 2011 at 8:45 AM, Chris Metcalf <cmetcalf@tilera.com> wrote: > Commit 8d7718aa082aaf30a0b4989e1f04858952f941bc changed "int" > to "u32" in the prototypes but not the definition. > I missed this when I saw the patch go by on LKML. > > We cast "u32 *" to "int *" since we are tying into the underlying > atomics framework, and atomic_t uses int as its value type. > > Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
Reviewed-by: Michel Lespinasse <walken@google.com>
Looks fine. I had held off from changing types within futex_atomic_op_inuser() because the signed-ness of oparg and cmparg was important there, but I agree changing at least the user pointer types in futex_* operations is nice and safe.
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |