[lkml]   [2011]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] drivers/watchdog/s3c2410_wdt.c: Convert release_resource to release_region/release_mem_region
Hi Julia,

> Actually, I later realized that one can also use the result of
> request_mem_region in place of res. Even though it is not the same
> structure, it has the same start and end field information, which is the
> only information that is used. But I haven't had a chance to send a patch
> that follows that strategy. So if it is preferred to keep res, then that
> can be done.

If you look at the driver then you will see that it will use wdt_base to control the device:
static void __iomem *wdt_base;
res=platform_get_resource(pdev, IORESOURCE_MEM, 0);
wdt_base = ioremap(res->start, size);

So the memory resource is only used for:
1) requesting the memory region
2) ioremapping the memory so that we can use the registers.

My opinion: res can go out so that wdt_mem and wdt_irq get similar platform resource info.

Kind regards,

 \ /
  Last update: 2011-03-18 10:15    [W:0.027 / U:14.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site