lkml.org 
[lkml]   [2011]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/16] [media] au6610: get rid of on-stack dma buffer
    On Fri, 18 Mar 2011 18:34:58 +0200
    Antti Palosaari <crope@iki.fi> wrote:

    > On 03/15/2011 10:43 AM, Florian Mickler wrote:
    > > usb_control_msg initiates (and waits for completion of) a dma transfer using
    > > the supplied buffer. That buffer thus has to be seperately allocated on
    > > the heap.
    > >
    > > In lib/dma_debug.c the function check_for_stack even warns about it:
    > > WARNING: at lib/dma-debug.c:866 check_for_stack
    > >
    > > Note: This change is tested to compile only, as I don't have the hardware.
    > >
    > > Signed-off-by: Florian Mickler<florian@mickler.org>
    >
    >
    > This patch did not found from patchwork! Probably skipped due to broken
    > Cc at my contact. Please resend.
    >
    > Anyhow, I tested and reviewed it.
    >
    > Acked-by: Antti Palosaari <crope@iki.fi>
    > Reviewed-by: Antti Palosaari <crope@iki.fi>
    > Tested-by: Antti Palosaari <crope@iki.fi>
    >
    > [1] https://patchwork.kernel.org/project/linux-media/list/
    >
    > Antti
    >

    Yes, there was some broken adressing on my side. Sorry.

    Thanks for review && test! I will resend (hopefully this weekend) the
    series when I reviewed some of the other patches if it is
    feasible/better to use prealocated memory as suggested by Mauro.

    How often does au6610_usb_msg get called in normal operation? Should it
    use preallocated memory?

    Regards,
    Flo


    \
     
     \ /
      Last update: 2011-03-18 22:29    [W:4.475 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site