Messages in this thread Patch in this message | | | Date | Fri, 18 Mar 2011 09:39:06 -0700 | Subject | Re: [Xen-devel] [PATCH -v3] watchdog, SP5100: Check if firmware has set correct value in tcobase. | From | Yinghai Lu <> |
| |
On Fri, Mar 18, 2011 at 6:10 AM, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote: > On Wed, Mar 16, 2011 at 08:01:07PM -0700, Yinghai Lu wrote: >> >> Stefano found SP5100 TCO watchdog driver using wrong address. >> >> [ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01 >> [ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1 >> >> and e820 said that range is RAM. >> >> We should check if we can use that reading out. BIOS could just program wrong address there. >> >> -v2: Mike pointed out one path need one release. >> -v3: corrected logic checking with request_mem_region_exclusive() >> Found by Konrad. > > Yinghai: > Not sure what you are using as a base, but I had to modify this patch > to go on top of 2.6.38. Here is the patch that applies cleanly:
after
commit 4562f53940432369df88e195ef8f9b642bdf7cd6 Author: Wim Van Sebroeck <wim@iguana.be> Date: Mon Feb 21 12:16:44 2011 +0000
watchdog: convert to DEFINE_PCI_DEVICE_TABLE
Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE tables.
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
diff --git a/drivers/watchdog/sp5100_tco.c b/drivers/watchdog/sp5100_tco.c index 8083728..1bc4938 100644 --- a/drivers/watchdog/sp5100_tco.c +++ b/drivers/watchdog/sp5100_tco.c @@ -259,7 +259,7 @@ static struct miscdevice sp5100_tco_miscdev = { * register a pci_driver, because someone else might * want to register another driver on the same PCI id. */ -static struct pci_device_id sp5100_tco_pci_tbl[] = { +static DEFINE_PCI_DEVICE_TABLE(sp5100_tco_pci_tbl) = { { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_SBX00_SMBUS, PCI_ANY_ID, PCI_ANY_ID, }, { 0, }, /* End of list */ commit 15e28bf130081a574192fb934b832ac7d07739f7 Author: Priyanka Gupta <priyankag@google.com> Date: Mon Oct 25 17:58:04 2010 -0700
watchdog: Add support for sp5100 chipset TCO
This driver adds /dev/watchdog support for the AMD sp5100 aka SB7x0 chipsets.
It follows the same conventions found in other /dev/watchdog drivers.
Signed-off-by: Priyanka Gupta <priyankag@google.com> Signed-off-by: Mike Waychison <mikew@google.com> Signed-off-by: Wim Van Sebroeck <wim@iguana.be> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |