Messages in this thread | | | Date | Thu, 17 Mar 2011 14:20:42 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH 3/4] Check whether pages are poisoned before copying |
| |
(2011/03/17 13:14), Andi Kleen wrote: > On Thu, Mar 17, 2011 at 11:32:55AM +0900, Hidetoshi Seto wrote: >> So to avoid the above problem, add poison checks for both of 4K pages >> and the THP before copying in __collapse_huge_page_copy(). > > I don't think you need the check for the huge page -- it should not be allocated > in this case.
Is there no case that the THP is once allocated but poison flag is set before copy? Though I know it is one of corner cases, having this check for THP is worse than nothing.
Thanks, H.Seto
| |