lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)
On Thu, Mar 17, 2011 at 02:35:42PM -0700, Tony Luck wrote:
> mutex_unlock(&root->d_inode->i_mutex);
>
> - if (!pstore_writefile(inode, dentry, data, size))
> - goto fail_write;
> + memcpy(private->data, data, size);
> + inode->i_size = private->size = size;
>
> inode->i_private = private;

Better move that before d_add()

> if (IS_ERR(root))
> - return -ENOMEM;
> -
> - mnt->mnt_root = root;
> - mnt->mnt_sb = root->d_sb;
> - pstore_mnt = mnt;
> + return root;
>
> - return 0;
> + return root;

*blink*
if (IS_ERR(root))
return root;
return root;
... or am I misreading the patch?


\
 
 \ /
  Last update: 2011-03-17 23:45    [from the cache]
©2003-2011 Jasper Spaans