lkml.org 
[lkml]   [2011]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: make checkpatch warn about memset with swapped arguments.
    From
    Date
    On Thu, 2011-03-17 at 14:11 -0700, Andrew Morton wrote:
    > On Thu, 17 Mar 2011 16:37:04 -0400

    >
    > Dave's patch is tested (I assume), so it wins ;)

    I did test mine :) Checked it out before posting. Although I didn't make
    a patch out of it.

    >
    > Maybe it's just me, but I think it would be better to use bzero() for
    > this operation - it's more readable and it can't be screwed up. Then
    > checkpatch checks for memset(xxx, 0, xxx) and for memset(xxx, xxx, 0)
    > and says "hey, use bzero".

    Honestly, I've never had the issues with memset. Maybe back in college.
    But heh, whatever.

    -- Steve




    \
     
     \ /
      Last update: 2011-03-17 22:41    [W:0.030 / U:91.956 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site