Messages in this thread | | | Date | Thu, 17 Mar 2011 19:25:36 +0100 | Subject | Re: um: WARNING: at kernel/futex.c:786 __unqueue_futex | From | Geert Uytterhoeven <> |
| |
On Thu, Mar 17, 2011 at 19:16, Steven Rostedt <rostedt@goodmis.org> wrote: > On Thu, 2011-03-17 at 18:02 +0100, Eric Dumazet wrote: >> Le jeudi 17 mars 2011 à 12:55 -0400, Steven Rostedt a écrit : >> > Here, test this patch. I'm in the process of committing it now. >> > It will be two patches, one for the WARN_ON_SMP() change, the other for >> > the futex change. >> > >> > -- Steve >> > >> > diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h >> > index c2c9ba0..25f1e9e 100644 >> > --- a/include/asm-generic/bug.h >> > +++ b/include/asm-generic/bug.h >> > @@ -168,7 +168,7 @@ extern void warn_slowpath_null(const char *file, const int line); >> > #ifdef CONFIG_SMP >> > # define WARN_ON_SMP(x) WARN_ON(x) >> > #else >> > -# define WARN_ON_SMP(x) do { } while (0) >> > +# define WARN_ON_SMP(x) ({0;}) >> > #endif >> > >> >> You meant : >> >> # define WARN_ON_SMP(x) ({x;}) >> >> or >> >> # define WARN_ON_SMP(x) do { } while (x, 0) >> >> ? >> > > Does if (do { } while (x, 0)) work?
No.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |