Messages in this thread | | | Subject | Re: [PATCH 02/17] mm: mmu_gather rework | From | Peter Zijlstra <> | Date | Wed, 16 Mar 2011 22:08:21 +0100 |
| |
On Wed, 2011-03-16 at 21:15 +0100, Geert Uytterhoeven wrote: > On Wed, Mar 16, 2011 at 19:55, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > On Thu, 2011-03-10 at 15:50 +0000, Mel Gorman wrote: > > > >> > +static inline void > >> > +tlb_gather_mmu(struct mmu_gather *tlb, struct mm_struct *mm, unsigned int full_mm_flush) > >> > { > >> > >> checkpatch will bitch about line length. > > > > I did a s/full_mm_flush/fullmm/ which puts the line length at 81. At > > which point I'll ignore it ;-) > > But what does "fullmm" mean here? Shouldn't that be documented. > BTW, the function no longer returns a struct, but void, so the documentation > should be updated for sure.
You're talking about the comment right? I'll update that. I was also considering writing Documentation/mmugather.txt, but that's a slightly bigger undertaking.
| |