Messages in this thread | | | Date | Wed, 16 Mar 2011 10:20:50 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v2 2.6.38-rc8-tip 11/20] 11: uprobes: slot allocation for uprobes |
| |
* Stephen Wilson <wilsons@start.ca> [2011-03-15 16:31:17]:
> > On Mon, Mar 14, 2011 at 07:06:10PM +0530, Srikar Dronamraju wrote: > > diff --git a/kernel/fork.c b/kernel/fork.c > > index de3d10a..0afa0cd 100644 > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -551,6 +551,7 @@ void mmput(struct mm_struct *mm) > > might_sleep(); > > > > if (atomic_dec_and_test(&mm->mm_users)) { > > + uprobes_free_xol_area(mm); > > exit_aio(mm); > > ksm_exit(mm); > > khugepaged_exit(mm); /* must run before exit_mmap */ > > @@ -677,6 +678,9 @@ struct mm_struct *dup_mm(struct task_struct *tsk) > > memcpy(mm, oldmm, sizeof(*mm)); > > > > /* Initializing for Swap token stuff */ > > +#ifdef CONFIG_UPROBES > > + mm->uprobes_xol_area = NULL; > > +#endif > > mm->token_priority = 0; > > mm->last_interval = 0; > > Perhaps move the uprobes_xol_area initialization away from that comment? > A few lines down beside the hugepage #ifdef would read a bit better.
Okay, Will do.
-- Thanks and Regards Srikar
| |