Messages in this thread | | | Subject | Re: [PATCH 1/8] drivers/random: Cache align ip_random better | From | Matt Mackall <> | Date | Tue, 15 Mar 2011 21:54:14 -0500 |
| |
On Sun, 2011-03-13 at 20:20 -0400, George Spelvin wrote: > Cache aligning the secret[] buffer makes copying from it infinitesimally > more efficient.
Acked-by: Matt Mackall <mpm@selenic.com>
> --- > drivers/char/random.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/char/random.c b/drivers/char/random.c > index 72a4fcb..4bcc4f2 100644 > --- a/drivers/char/random.c > +++ b/drivers/char/random.c > @@ -1417,8 +1417,8 @@ static __u32 twothirdsMD4Transform(__u32 const buf[4], __u32 const in[12]) > #define HASH_MASK ((1 << HASH_BITS) - 1) > > static struct keydata { > - __u32 count; /* already shifted to the final position */ > __u32 secret[12]; > + __u32 count; /* already shifted to the final position */ > } ____cacheline_aligned ip_keydata[2]; > > static unsigned int ip_cnt;
-- Mathematics is the supreme nostalgia of our time.
| |