lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/12] perf top: Remove redundant syme->origin field
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    We can get it from syme->map->dso->kernel (that should be renamed to
    origin, but leave this for another patch).

    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@elte.hu>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    LKML-Reference: <new-submission>
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-top.c | 1 -
    tools/perf/util/top.c | 4 ++--
    tools/perf/util/top.h | 1 -
    3 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
    index 4bf6e02..4976400 100644
    --- a/tools/perf/builtin-top.c
    +++ b/tools/perf/builtin-top.c
    @@ -782,7 +782,6 @@ static void perf_event__process_sample(const union perf_event *event,
    if (!syme->skip) {
    struct perf_evsel *evsel;

    - syme->origin = origin;
    evsel = perf_evlist__id2evsel(top.evlist, sample->id);
    assert(evsel != NULL);
    syme->count[evsel->idx]++;
    diff --git a/tools/perf/util/top.c b/tools/perf/util/top.c
    index fcfb777..a11f607 100644
    --- a/tools/perf/util/top.c
    +++ b/tools/perf/util/top.c
    @@ -184,9 +184,9 @@ float perf_top__decay_samples(struct perf_top *top, struct rb_root *root)
    if (syme->snap_count != 0) {

    if ((top->hide_user_symbols &&
    - syme->origin == PERF_RECORD_MISC_USER) ||
    + syme->map->dso->kernel == DSO_TYPE_USER) ||
    (top->hide_kernel_symbols &&
    - syme->origin == PERF_RECORD_MISC_KERNEL)) {
    + syme->map->dso->kernel == DSO_TYPE_KERNEL)) {
    perf_top__remove_active_sym(top, syme);
    continue;
    }
    diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h
    index 96a7831..ba111b2 100644
    --- a/tools/perf/util/top.h
    +++ b/tools/perf/util/top.h
    @@ -17,7 +17,6 @@ struct sym_entry {
    unsigned long snap_count;
    double weight;
    int skip;
    - u8 origin;
    struct map *map;
    unsigned long count[0];
    };
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2011-03-15 21:07    [W:0.022 / U:1.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site