Messages in this thread | | | Date | Tue, 15 Mar 2011 21:47:52 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction. |
| |
> > > > rcu_read_lock(); > > tsk = mm->owner; > > if (tsk) > > get_task_struct(tsk); > > rcu_read_unlock(); > > if (!tsk) > > return ret; > > > > Probably looks cleaner. > > Yes, plus we should do "tsk = rcu_dereference(mm->owner);" and wrap the > whole thing in a static uprobes_get_mm_owner() or similar. >
Okay, will do that.
-- Thanks and Regards Srikar
| |