lkml.org 
[lkml]   [2011]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2.6.38-rc8-tip 7/20] 7: uprobes: store/restore original instruction.
    On Mon, 14 Mar 2011, Srikar Dronamraju wrote:
    > static int install_uprobe(struct mm_struct *mm, struct uprobe *uprobe)
    > {
    > - int ret = 0;
    > + struct task_struct *tsk;
    > + int ret = -EINVAL;
    >
    > - /*TODO: install breakpoint */
    > - if (!ret)
    > + get_task_struct(mm->owner);

    Increment task ref before checking for NULL ?

    > + tsk = mm->owner;
    > + if (!tsk)
    > + return ret;
    > +

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2011-03-15 15:45    [W:4.306 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site