lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] SUNRPC: svc_register error overwritten in next iteration
On Sat, Mar 12, 2011 at 02:27:35PM +0100, roel wrote:
> The break is in the inner loop, the svc_register() error is overwritten
> in the next iteration. Only the error in the last iteration is returned.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> net/sunrpc/svc.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> Is this needed?
>
> diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
> index 08e05a8..5fd08c0 100644
> --- a/net/sunrpc/svc.c
> +++ b/net/sunrpc/svc.c
> @@ -889,6 +889,8 @@ int svc_register(const struct svc_serv *serv, const int family,
> if (error < 0)
> break;

May as well just "goto out" or "return error" here?

But: aren't we missing some cleanup? If we succesfully register one
program then fail at a second one, don't we need to unregister the
first?

--b.

> }
> + if (error < 0)
> + break;
> }
>
> return error;


\
 
 \ /
  Last update: 2011-03-14 23:39    [W:0.064 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site