lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/21] Staging: hv: Cleanup root device handling
On Mon, Mar 14, 2011 at 07:54:29PM +0000, KY Srinivasan wrote:
>
>
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com]
> > Sent: Monday, March 14, 2011 3:34 PM
> > To: KY Srinivasan
> > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang; Mike
> > Sterling; Abhishek Kane (Mindtree Consulting PVT LTD)
> > Subject: Re: [PATCH 10/21] Staging: hv: Cleanup root device handling
> >
> > On Thu, Mar 10, 2011 at 02:08:06PM -0800, K. Y. Srinivasan wrote:
> > > Now we can complete the cleanup of the root device
> > > management. Use the preferred APIs for creating and
> > > managing the root device. As part of this cleanup get rid
> > > of the root device object from vmbus_driver_context.
> >
> > I don't understand, what is the "root device"?
>
> This would be the device under /sys/devices that all
> other hyperv devices would be grouped under.
> This notion of the root device existed in the existing
> code; however its creation and management was
> unnecessarily complicated.

But that is what your new pci device should be, not a separate one. Why
not use that instead?

Actually, how are things looking then? You have a pci device, with no
children, yet the root device has the children devices? That doesn't
really make sense now does it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2011-03-14 21:05    [W:0.036 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site