lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/21] tcm_loop: Add multi-fabric Linux/SCSI LLD fabric module
On Mon, Mar 14, 2011 at 04:06:15AM -0700, Nicholas A. Bellinger wrote:
> drivers/target/Kconfig | 2 +
> drivers/target/Makefile | 3 +
> drivers/target/tcm_loop/Kconfig | 11 +
> drivers/target/tcm_loop/Makefile | 5 +
> drivers/target/tcm_loop/tcm_loop_configfs.c | 643 ++++++++++++++++++++++++
> drivers/target/tcm_loop/tcm_loop_core.h | 141 ++++++
> drivers/target/tcm_loop/tcm_loop_fabric.c | 472 +++++++++++++++++
> drivers/target/tcm_loop/tcm_loop_fabric_scsi.c | 574 +++++++++++++++++++++
> 8 files changed, 1851 insertions(+), 0 deletions(-)

Please descide on a naming scheme for the frontend modules. You have
tcm_loop for thise one, and just iscsi for the iscsi frontend. I'm
not sure what tcm actually stands for, but a common prefix defintively
is helpful.

And for only about 1700 lines of code I really don't see why it needs to be
split into multiple implementation files.



\
 
 \ /
  Last update: 2011-03-14 16:01    [W:0.160 / U:3.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site