lkml.org 
[lkml]   [2011]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] SUNRPC: svc_register error overwritten in next iteration
    From
    Date

    On Mar 12, 2011, at 8:27 AM, roel wrote:

    > The break is in the inner loop, the svc_register() error is overwritten
    > in the next iteration. Only the error in the last iteration is returned.
    >
    > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    > ---
    > net/sunrpc/svc.c | 2 ++
    > 1 files changed, 2 insertions(+), 0 deletions(-)
    >
    > Is this needed?

    Maybe. Did you encounter a problem here?

    > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
    > index 08e05a8..5fd08c0 100644
    > --- a/net/sunrpc/svc.c
    > +++ b/net/sunrpc/svc.c
    > @@ -889,6 +889,8 @@ int svc_register(const struct svc_serv *serv, const int family,
    > if (error < 0)
    > break;
    > }
    > + if (error < 0)
    > + break;
    > }
    >
    > return error;

    --
    Chuck Lever
    chuck[dot]lever[at]oracle[dot]com






    \
     
     \ /
      Last update: 2011-03-14 13:49    [W:0.021 / U:30.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site