lkml.org 
[lkml]   [2011]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/24] staging: serqt_usb2: Remove NULL check before kfree
    Date
    This patch was generated by the following semantic patch:
    // <smpl>
    @@ expression E; @@
    - if (E != NULL) { kfree(E); }
    + kfree(E);

    @@ expression E; @@
    - if (E != NULL) { kfree(E); E = NULL; }
    + kfree(E);
    + E = NULL;
    // </smpl>

    Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
    ---
    drivers/staging/serqt_usb2/serqt_usb2.c | 3 +--
    1 files changed, 1 insertions(+), 2 deletions(-)

    diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
    index 27841ef..2be2d88 100644
    --- a/drivers/staging/serqt_usb2/serqt_usb2.c
    +++ b/drivers/staging/serqt_usb2/serqt_usb2.c
    @@ -1098,8 +1098,7 @@ static void qt_close(struct usb_serial_port *port)

    if (qt_port->write_urb) {
    /* if this urb had a transfer buffer already (old tx) free it */
    - if (qt_port->write_urb->transfer_buffer != NULL)
    - kfree(qt_port->write_urb->transfer_buffer);
    + kfree(qt_port->write_urb->transfer_buffer);
    usb_free_urb(qt_port->write_urb);
    }

    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-03-13 06:45    [W:0.020 / U:2.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site