lkml.org 
[lkml]   [2011]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/24] staging: tidspbridge: Remove NULL check before kfree
    Date
    This patch was generated by the following semantic patch:
    // <smpl>
    @@ expression E; @@
    - if (E != NULL) { kfree(E); }
    + kfree(E);

    @@ expression E; @@
    - if (E != NULL) { kfree(E); E = NULL; }
    + kfree(E);
    + E = NULL;
    // </smpl>

    Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
    ---
    drivers/staging/tidspbridge/core/chnl_sm.c | 3 +--
    drivers/staging/tidspbridge/pmgr/dbll.c | 3 +--
    2 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/staging/tidspbridge/core/chnl_sm.c b/drivers/staging/tidspbridge/core/chnl_sm.c
    index 3c05d7c..8381130 100644
    --- a/drivers/staging/tidspbridge/core/chnl_sm.c
    +++ b/drivers/staging/tidspbridge/core/chnl_sm.c
    @@ -828,8 +828,7 @@ out_err:
    free_chirp_list(&pchnl->io_requests);
    free_chirp_list(&pchnl->free_packets_list);

    - if (sync_event)
    - kfree(sync_event);
    + kfree(sync_event);

    if (pchnl->ntfy_obj) {
    ntfy_delete(pchnl->ntfy_obj);
    diff --git a/drivers/staging/tidspbridge/pmgr/dbll.c b/drivers/staging/tidspbridge/pmgr/dbll.c
    index 2e20f78e..31da62b 100644
    --- a/drivers/staging/tidspbridge/pmgr/dbll.c
    +++ b/drivers/staging/tidspbridge/pmgr/dbll.c
    @@ -272,8 +272,7 @@ void dbll_delete(struct dbll_tar_obj *target)
    DBC_REQUIRE(refs > 0);
    DBC_REQUIRE(zl_target);

    - if (zl_target != NULL)
    - kfree(zl_target);
    + kfree(zl_target);

    }

    --
    1.7.3.4


    \
     
     \ /
      Last update: 2011-03-13 06:45    [W:0.020 / U:0.344 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site