lkml.org 
[lkml]   [2011]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Platform: add Samsung Laptop platform driver
    On Sun, Mar 13, 2011 at 09:17:53AM -0700, Greg KH wrote:
    > On Sun, Mar 13, 2011 at 12:03:20PM +0200, Nikolai Kondrashov wrote:
    > > Sometime ago I've found this hack on some forum, which I use currently
    > > to set the brightness:
    > >
    > > setpci -s 00:02.0 f4.b="$HEX_BYTE"
    > >
    > > It allows finer control of the brightness, but it seems it operates directly
    > > on the video card PCI register. I assume there is no sane way to use
    > > this interface from the platform driver, right?
    >
    > Yes, do not do this, it causes all sorts of problems in the end, not the
    > least being the BIOS doesn't know what is going on at all as you are
    > changing the brightness without it knowing it.

    It's also modifying configuration that belongs to a device being managed
    by another driver, so it's the kind of thing we frown upon. Having said
    that, the Intel driver should gain native backlight support in .39.

    --
    Matthew Garrett | mjg59@srcf.ucam.org


    \
     
     \ /
      Last update: 2011-03-13 17:31    [W:4.331 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site